Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore privacy image generation performance improvements #594

Open
jbmorley opened this issue May 8, 2023 · 0 comments
Open

Explore privacy image generation performance improvements #594

jbmorley opened this issue May 8, 2023 · 0 comments
Labels
enhancement New feature or request ios Impacts the iOS app performance
Milestone

Comments

@jbmorley
Copy link
Collaborator

jbmorley commented May 8, 2023

When I was working on #590, I came across an NSHipster article which suggested that image scaling performance varied vastly between different options and that the CIImage approach might be one of the slower ones. It might be worth revisiting this to see if we can make updates more responsive.

https://nshipster.com/image-resizing/

Of course, perhaps the easiest approach would be to generate the privacy mode once (as @tomsci had in his original implementation), rather than generating it on every upload (though this does gain us some flexibility).

@jbmorley jbmorley added enhancement New feature or request ios Impacts the iOS app performance labels May 8, 2023
@jbmorley jbmorley added this to the iOS Future milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ios Impacts the iOS app performance
Projects
None yet
Development

No branches or pull requests

1 participant