Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle token decimals generically #106

Open
brenzi opened this issue Jan 4, 2022 · 0 comments · May be fixed by #107
Open

handle token decimals generically #106

brenzi opened this issue Jan 4, 2022 · 0 comments · May be fixed by #107
Assignees
@anizeani

Comments

@brenzi
Copy link
Contributor

brenzi commented Jan 4, 2022

Token decimals can be derived from js/api and should not be hardcoded

The following should be done properly (generic decimals and better typing: this here can overflow?):

crowdloan/src/Participate.js

Line 431 in 6cd1fc6

amount * Math.pow(10, 12),

And this also

crowdloan/src/Why.js

Line 95 in c269fdd

{toUnit(crowdLoan.raised, 12)}<br/>

@brenzi brenzi mentioned this issue Jan 4, 2022
Merged
@anizeani anizeani self-assigned this Jan 5, 2022
@anizeani anizeani linked a pull request Jan 5, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anizeani anizeani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add estimates refactor decimals change copy icon integritee-network/crowdloan
2 participants
@brenzi @anizeani