Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 error detection broken on Safari in Manifest v3 #1046

Open
cgorringe opened this issue Sep 26, 2024 · 3 comments
Open

404 error detection broken on Safari in Manifest v3 #1046

cgorringe opened this issue Sep 26, 2024 · 3 comments
Labels
bug Medium or low-priority bug can't fix Bug can't be fixed in our code critical Serious or high-priority bug

Comments

@cgorringe
Copy link
Member

Describe the bug

In the latest v3.4.2 code which upgraded to Manifest v3, the extension will not work in Safari without removing the webRequest permission and commenting out the chrome.webRequest functions. Unfortunately, the result of doing so removes the ability for the extension to detect 4xx error codes such as 404 Not Found. When this feature is turned on in Settings, the red dot and/or popup will no longer appear on a 404 page.

Environment (please complete the following information):

  • Webextension version: v3.4.2 (modified)
  • Browser + version: Safari 18.0
  • OS + version: macOS Sonoma 14.7
@cgorringe cgorringe added bug Medium or low-priority bug critical Serious or high-priority bug labels Sep 26, 2024
@cgorringe
Copy link
Member Author

Testing this on branch safari-manifest-v3

@cgorringe cgorringe added the can't fix Bug can't be fixed in our code label Sep 29, 2024
@cgorringe
Copy link
Member Author

I think this is a bug in Safari. It should support webRequest functions. I don't know why it doesn't in Manifest v3. It appears we need this to detect any kind of http error code.

@cgorringe
Copy link
Member Author

Filed a compatibility report on MDM here: mdn/browser-compat-data#24571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Medium or low-priority bug can't fix Bug can't be fixed in our code critical Serious or high-priority bug
Projects
None yet
Development

No branches or pull requests

1 participant