From df2e81be2523d059724f07cc7089bbf2af323d7f Mon Sep 17 00:00:00 2001 From: ebeaty-cisco <150805304+ebeaty-cisco@users.noreply.github.com> Date: Thu, 9 Jan 2025 12:27:15 +0000 Subject: [PATCH 1/2] Add terraform to ubuntu image used to run commit checks (#30) --- .github/workflows/pre-commit.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 40b1116..333c20f 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -17,6 +17,10 @@ jobs: with: fetch-depth: 0 + - uses: hashicorp/setup-terraform@v3 + with: + terraform_version: "1.7.1" + - name: "Setup prerequisites" # yamllint disable rule:line-length run: | From 4654c73fd56628633862a1021b55db0112ec8835 Mon Sep 17 00:00:00 2001 From: ebeaty-cisco <150805304+ebeaty-cisco@users.noreply.github.com> Date: Mon, 27 Jan 2025 14:08:08 +0000 Subject: [PATCH 2/2] . (#33) --- aws-quickstart | 11 ++++++----- examples/bootstrap/README.md | 2 +- examples/bootstrap/variables.tf | 2 +- tests/ut/test_eks.py | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/aws-quickstart b/aws-quickstart index 19fd321..042d119 100755 --- a/aws-quickstart +++ b/aws-quickstart @@ -40,15 +40,15 @@ OPTIONS: Destroy the workload and infrastructure. --kubernetes-version - Kubernetes version to use. This must be one of: 1.24, 1.25, 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 - (default: 1.31). + Kubernetes version to use. This must be one of: 1.24, 1.25, 1.26, 1.27, 1.28, 1.29, 1.30, 1.31, 1.32 + (default: 1.32). EOF } # Default arguments. AMI_ID="" DESTROY="" -KUBERNETES_VERSION="1.31" +KUBERNETES_VERSION="1.32" XR_USERNAME="" XR_PASSWORD="" BASTION_REMOTE_ACCESS_CIDR_BLOCKS="" @@ -108,8 +108,9 @@ if [ "${KUBERNETES_VERSION}" != "1.24" ] && [ "${KUBERNETES_VERSION}" != "1.28" ] && [ "${KUBERNETES_VERSION}" != "1.29" ] && [ "${KUBERNETES_VERSION}" != "1.30" ] && - [ "${KUBERNETES_VERSION}" != "1.31" ]; then - >&2 echo "error: Kubernetes version (--kubernetes-version) must be one of: 1.24, 1.25, 1.26, 1.27, 1.28, 1.29, 1.30, 1.31" + [ "${KUBERNETES_VERSION}" != "1.31" ] && + [ "${KUBERNETES_VERSION}" != "1.32" ]; then + >&2 echo "error: Kubernetes version (--kubernetes-version) must be one of: 1.24, 1.25, 1.26, 1.27, 1.28, 1.29, 1.30, 1.31, 1.32" ERROR=1 fi diff --git a/examples/bootstrap/README.md b/examples/bootstrap/README.md index e2a7ff0..5bd78a3 100644 --- a/examples/bootstrap/README.md +++ b/examples/bootstrap/README.md @@ -42,7 +42,7 @@ terraform destroy |------|-------------|------|---------|:--------:| | [azs](#input\_azs) | List of exactly two availability zones in the currently configured AWS region.
A private subnet and a public subnet is created in each of these availability zones.
Each cluster node is launched in one of the private subnets.
If null, then the first two availability zones in the currently configured AWS region is used. | `list(string)` | `null` | no | | [bastion\_remote\_access\_cidr\_blocks](#input\_bastion\_remote\_access\_cidr\_blocks) | Allowed CIDR blocks for external SSH access to the Bastion instance.
This must be a list of strings.
If null, then access to the Bastion instance is prevented. | `list(string)` | n/a | yes | -| [cluster\_version](#input\_cluster\_version) | Cluster version | `string` | `"1.31"` | no | +| [cluster\_version](#input\_cluster\_version) | Cluster version | `string` | `"1.32"` | no | | [name\_prefix](#input\_name\_prefix) | Used as a prefix for the 'Name' tag for each created resource.
If null, then a random name 'xrd-terraform-[0-9a-z]{8}' is used. | `string` | `null` | no | ## Outputs diff --git a/examples/bootstrap/variables.tf b/examples/bootstrap/variables.tf index 85d1636..f5d8d1d 100644 --- a/examples/bootstrap/variables.tf +++ b/examples/bootstrap/variables.tf @@ -35,6 +35,6 @@ variable "bastion_remote_access_cidr_blocks" { variable "cluster_version" { description = "Cluster version" type = string - default = "1.31" + default = "1.32" nullable = false } diff --git a/tests/ut/test_eks.py b/tests/ut/test_eks.py index 6126724..93c8a92 100644 --- a/tests/ut/test_eks.py +++ b/tests/ut/test_eks.py @@ -101,7 +101,7 @@ def security_group(ec2: EC2ServiceResource, vpc: Vpc) -> SecurityGroup: @pytest.fixture def base_vars(subnet1: Subnet, subnet2: Subnet) -> dict[str, Any]: return { - "cluster_version": "1.31", + "cluster_version": "1.32", "name": str(uuid.uuid4()), "subnet_ids": [subnet1.id, subnet2.id], }