Update to use the new string representation of a Multihash. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Aug 30, 2018
kevina
force-pushed
the
kevina/newmultihash
branch
from
70b07e9 to
78513ff
Compare
kevina
force-pushed
the
kevina/newmultihash
branch
from
78513ff to
07b4cde
Compare
kevina
force-pushed
the
kevina/newmultihash
branch
from
07b4cde to
d585ff3
Compare
|
@Stebalien can you have a look at this. This change needs to go in if we are going to update to the string representation of a multihash. It also has a few other optimizations in. |
|
Note: This is based on #71. Please approve but don't merge. It has a gx-depenecy on a non-pinned hash that I will get ride of once multiformats/go-multihash#84 is merged. |
Stebalien
approved these changes
Aug 31, 2018
|
@Stebalien is this still relevant? Seems everything has already migrated to strings... |
|
The goal was to also migrate multihash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of #47