TQDM workaround due to unresponsive maintainer #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqdm has an incorrect detection of ZMQInteractiveShell when launch via a scheduler that bypass IPKernelApp. Think of JupyterHub cluster spawners and co. As of end of Feb 2025, the maintainer has been unresponsive for 5 months, to our fix, so we implement a workaround. I don't like it but we have few other choices. See `https://github.com/tqdm/tqdm/pull/1628`
krassowski
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
I can see that even once the maintainer of tqdm has some more time, they can take a while to respone as there is a a few upstream PRs related to improving notebook autodetection:
- Improve robustness of IPykernel detection tqdm/tqdm#1628 (ours)
- Add support for
TQDM_NOTEBOOKenvironment variable tqdm/tqdm#1655 - Add support for Spyder in tqdm.auto tqdm/tqdm#1559
Not sure if we can provide any feedback on the other PRs, but if there are any thoughts we could share to help with review upstream, this might help to move it forward.
minrk
reviewed
Feb 26, 2025
|
To backport. |
Co-authored-by: Min RK <benjaminrk@gmail.com>
Carreau
commented
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdmhas an incorrect detection of ZMQInteractiveShell when launch via a scheduler that bypass IPKernelApp. Think of JupyterHub cluster spawners and co.As of end of Feb 2025, the maintainer has been unresponsive for 5 months, to our fix, so we implement a workaround. I don't like it but we have few other choices.
See tqdm/tqdm#1628