New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_outstream #1369

Draft

davidbrochart wants to merge 1 commit into ipython:main from davidbrochart:test-outstream

Collaborator

davidbrochart commented Feb 27, 2025

No description provided.


          Fix test_outstream

662d232

davidbrochart marked this pull request as draft

February 27, 2025 10:48

Collaborator Author

davidbrochart commented Feb 27, 2025

test_outstream passes but it shouldn't, here is what is printed if pytest -s is used:

Traceback (most recent call last):
  File "/home/runner/work/ipykernel/ipykernel/ipykernel/iostream.py", line 392, in _watch_pipe_fd
    bts = os.read(self._fid, PIPE_BUFFER_SIZE)
AttributeError: 'OutStream' object has no attribute '_fid'

davidbrochart mentioned this pull request

Fix OutStream hooks not being called #1367

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet