fix: position packet want_response handling

Process valid position broadcasts with `want_response` true except from position requests with an empty payload (latitude and longitude are zeroes).
jamesarich · Oct 14, 2024 · af56fff · af56fff
1 parent eacf3a8
commit af56fff
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/src/main/java/com/geeksville/mesh/service/MeshService.kt b/app/src/main/java/com/geeksville/mesh/service/MeshService.kt
@@ -678,10 +678,13 @@ class MeshService : Service(), Logging {
 
                     // Handle new style position info
                     Portnums.PortNum.POSITION_APP_VALUE -> {
-                        if (data.wantResponse) return // ignore data from position requests
                         val u = MeshProtos.Position.parseFrom(data.payload)
                         // debug("position_app ${packet.from} ${u.toOneLineString()}")
-                        handleReceivedPosition(packet.from, u, dataPacket.time)
+                        if (data.wantResponse && u.latitudeI == 0 && u.longitudeI == 0) {
+                            debug("Ignoring nop position update from position request")
+                        } else {
+                            handleReceivedPosition(packet.from, u, dataPacket.time)
+                        }
                     }
 
                     // Handle new style user info