Scala Soundness scenario 9 to use mend/.within instead of try/catch
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mend/.withinis the idiomatic approach to exception handling in SoundnessBased on feedback from @propensive.
Jon, based on your feedback I was able to simply explicitly annotate the type of
reqasText raises HttpError, and that seemed to work. Let me know if you have any concerns with it.I also considered defining the
asyncblock within its own method (in fact I considered doing that for all scenarios earlier on), but decided against it to make the implementation more consistent with all the other implementations.