From 4c7faf73a288b41c1dea028fb3b3250698d91049 Mon Sep 17 00:00:00 2001 From: Joris Goosen Date: Wed, 27 Nov 2024 16:23:12 +0100 Subject: [PATCH] ok so the refresh serves a purpose --- Desktop/data/datasetpackage.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Desktop/data/datasetpackage.cpp b/Desktop/data/datasetpackage.cpp index f8a47b7e79..d8103f39cd 100644 --- a/Desktop/data/datasetpackage.cpp +++ b/Desktop/data/datasetpackage.cpp @@ -1634,13 +1634,12 @@ void DataSetPackage::setColumnName(size_t columnIndex, const std::string & newNa std::string oldName = getColumnName(columnIndex); - if(!column->setName(newName)) - return; - - - setManualEdits(true); - emit datasetChanged({}, {}, QMap({{tq(oldName), tq(newName)}}), false, false); - refresh(); + if(column->setName(newName)) + { + setManualEdits(true); + emit datasetChanged({}, {}, QMap({{tq(oldName), tq(newName)}}), false, false); + } + refresh(); //We do refresh in any case because then the emptied name of the column in variableswindow will get filled again } void DataSetPackage::setColumnTitle(size_t columnIndex, const std::string & newTitle)