Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of split-read end position in certain cases is off #19

Open
dminkley opened this issue Jan 29, 2019 · 0 comments
Open

Calculation of split-read end position in certain cases is off #19

dminkley opened this issue Jan 29, 2019 · 0 comments

Comments

@dminkley
Copy link

Hello,

After making the changes that address issue #18, I noticed that the first-occurring portion of some split reads indicated different SV endpoints than the other SVs (they generally ended in staggered positions within the DEL SV itself). Looking in to this, this portion of the add_split() function seems to be the problem:

            qs_pos, qe_pos = \
                    calc_query_pos_from_cigar(cigar, strand)
            splits[sr.HP][read.query_name].append(SplitRead(pos,
                                                  pos+qe_pos,
                                                  strand,
                                                  qs_pos))

pos+qe_pos is currently used to identify the endpoint of a split read fragment - this isn't always correct. For the first-occurring split read portion of reads on the negative strand, this will be wrong. Changing it to pos+(qe_end-qe_pos) seems to do the trick!

The example I used in issue #18 also demonstrates this issue.

-David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant