Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: hideParameters has inverted logic #224

Open
cgm-aw opened this issue Sep 10, 2024 · 1 comment · May be fixed by #225
Open

Bug: hideParameters has inverted logic #224

cgm-aw opened this issue Sep 10, 2024 · 1 comment · May be fixed by #225

Comments

@cgm-aw
Copy link

cgm-aw commented Sep 10, 2024 •
edited
Loading

Hi!

first things first: I really like your plugin and think it's very helpful :)

However, I noticed that the parameter hideParameters is buggy. Basically, its logic is inverted:

State Now Should
Omitted Without report Without report
True With report Without report
False Without report With report

I took the liberty of creating a bugfix branch for this: #225

Please take a look at it. I explicitly left the behavior alone when you omit the parameter to not cause surprises.

Best regards
@cgm-aw cgm-aw linked a pull request Sep 10, 2024 that will close this issue
Open
@jcgay
Copy link
Owner

jcgay commented Sep 20, 2024

Thanks for the kind words 😇.

I'll have a look at the PR in the next days, thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 224: Fix behavior of hideParameters parameter cgm-aw/maven-profiler
2 participants
@jcgay @cgm-aw