Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML Contrib #281

Open
SebastianStehle opened this issue May 5, 2022 · 0 comments
Open

MJML Contrib #281

SebastianStehle opened this issue May 5, 2022 · 0 comments

Comments

@SebastianStehle
Copy link

Hi,

I am the co-contributor of a .NET port: https://github.com/SebastianStehle/mjml-net and @skybber is working on a Java port which is based on .NET and the reference implementation. Our goals are similar: To be as fast as possible.

I think we have a few challenges in common:

  1. Discoverability: MJML is used a lot but only the official Node implementation:
  • I think we should ask the mjml team to provide a links to alternative implementations.
  • Furthermore It would make sense to combine our implementations under a Github Orga. I recommend "mjml-contrib", because I have seen this naming pattern very often.
  1. Testing: As much as I admire the work of the mjml-team, the test coverage is horrible. The main challenge is to test our implementation to work. We have written a few tests to compare the official templates with our implementation, but it was a challenge to make the HTML comparison working properly:
  • We could provide a CLI or tooling to test all implementations in one test suite.
  • We could use image snapshot testing to compare results (I have done this for another project).

Are you interested in these topics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant