Fix layout of options view for non-english languages

stefanhaller · stefanhaller · commit b31607250d02 · 2025-03-06T08:19:35.000+01:00
The width calculations didn't take multi-byte characters into account.
diff --git a/pkg/gui/options_map.go b/pkg/gui/options_map.go
@@ -119,7 +119,8 @@ func (self *OptionsMapMgr) formatBindingInfos(bindingInfos []bindingInfo) string
 		plainText := fmt.Sprintf("%s: %s", info.description, info.key)
 
 		// Check if adding the next formatted string exceeds the available width
-		if i > 0 && length+len(separator)+len(plainText) > width {
+		textLen := utils.StringWidth(plainText)
+		if i > 0 && length+len(separator)+textLen > width {
 			builder.WriteString(theme.OptionsFgColor.Sprint(separator + ellipsis))
 			break
 		}
@@ -131,7 +132,7 @@ func (self *OptionsMapMgr) formatBindingInfos(bindingInfos []bindingInfo) string
 			length += len(separator)
 		}
 		builder.WriteString(formatted)
-		length += len(plainText)
+		length += textLen
 	}
 
 	return builder.String()

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,8 @@ func (self *OptionsMapMgr) formatBindingInfos(bindingInfos []bindingInfo) string`
`119`	`119`	`plainText := fmt.Sprintf("%s: %s", info.description, info.key)`
`120`	`120`
`121`	`121`	`// Check if adding the next formatted string exceeds the available width`
`122`		`- if i > 0 && length+len(separator)+len(plainText) > width {`
	`122`	`+ textLen := utils.StringWidth(plainText)`
	`123`	`+ if i > 0 && length+len(separator)+textLen > width {`
`123`	`124`	`builder.WriteString(theme.OptionsFgColor.Sprint(separator + ellipsis))`
`124`	`125`	`break`
`125`	`126`	`}`
`@@ -131,7 +132,7 @@ func (self *OptionsMapMgr) formatBindingInfos(bindingInfos []bindingInfo) string`
`131`	`132`	`length += len(separator)`
`132`	`133`	`}`
`133`	`134`	`builder.WriteString(formatted)`
`134`		`- length += len(plainText)`
	`135`	`+ length += textLen`
`135`	`136`	`}`
`136`	`137`
`137`	`138`	`return builder.String()`