Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CERN Repositories should not be hard-coded #7

Open
michi42 opened this issue May 13, 2020 · 1 comment
Open

CERN Repositories should not be hard-coded #7

michi42 opened this issue May 13, 2020 · 1 comment

Comments

@michi42
Copy link
Contributor

michi42 commented May 13, 2020

The fix for #4 also allows to identify model pack repositories by URI. Therefore, there is no longer a need to hard-code the CERN GitLab repos in this service.

Instead, the initial list of enabled and disabled repositories could be passed e.g. by a system property or provided by an external package (e.g. jmad-modelpacks-cern)

@kaifox
Copy link
Member

kaifox commented May 13, 2020

Definitely!
The property value could be a uri itself to a json/yaml whatever... something like
-Djmad.modelpack.initial.repo.list=https://some/file/somewhere.yaml
... then it should be easy to maintain (can sit on some git itself).

and the file could then contain

  • A list of repos
  • and for each one an enabled/disabled flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants