Latest flymake (from emacs-straight) break eglot

[henrythebuilder]

Hi,
I have a Emacs(29.4)/Doomemacs configuration with eglot (and flycheck as checker), but with the latest updates for Doomemacs also flymake has been updated from emacs-straight and from there an error occurred.

latest flymake with error is the update 19b0a79 - and this matches the latest emacs sources (but not emacs 30 sources!)
previous flymake ok is the update 9c09445

I know this is probably not the ideal place for this type of message but I wanted to report it here to get help in better understanding the problem and its cause:

When I open a file (rust or c++ for example) I get this type of error:

"wrong-type-argument hash-table-p nil"

and this break the eglot hooks.

enabling toggle-debug-on-errorI was able to get the backtrace:

eglot--maybe-activate-editing-mode()
    run-hooks(eglot-managed-mode-hook)
        flycheck-eglot-mode()
            flycheck-eglot--setup()
                flymake-mode(-1)
                    maphash(#f(compiled-function (backend state) #<bytecode -0x11dca7a211c9e89>) nil)

and this is the eglot-managed-mode-hook value:

(doom-modeline-override-eglot
 doom-modeline-update-eglot
 flycheck-eglot-mode
 +lsp-optimization-mode)

it seems that in the flymake-mode function is missing a check on the flymake--state variable (which seems to be null):

   (maphash (lambda (_backend state)
               (flymake--clear-foreign-diags state))
             flymake--state)))

this is the full backtrace from a sample rust project:
eglot-error-backtrace.txt

Thank in advance for your help
Enrico

[joaotavora]

Doom is trying to turn off a mode that was never on in the first place. I've fixed the problem in the latest Emacs master.

[joaotavora]

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f7ff5f1ba4e87596cb4e055492b0e99321fd9950

[ijacquez]

Thank you very much @joaotavora. For anyone who stumbled across this, and cannot update Emacs at the moment, here is what I have implemented locally as a workaround:

(when (version<= "29.3" emacs-version)
  (advice-add
   'flymake-mode
   :before
   (lambda (&rest r)
     (unless flymake--state
       (setq-local flymake--state (make-hash-table))
       (message "Applying flymake-mode fix when turning flymake-mode off having never turned it on")))))

[henrythebuilder]

Thanks for the quick update, and thanks for your work!
👍