Only warn if files are present and invalid, not just missing

Author: joeyates

CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 14.5.2 - 2024-01-22
+
+### Changed
+
+* Suppressed mailbox and metadata '...is invalid' messages when these
+  files are missing. Now, the messages are printed when a file is
+  actually malformed.
+
 ## 14.5.1 - 2024-01-18
 
 ### Changed

lib/imap/backup/serializer.rb

@@ -102,8 +102,10 @@ def validate!
         @validated = true
         return true
       end
-      Logger.logger.info("Metadata file '#{imap.pathname}' is invalid") if !imap_valid
-      Logger.logger.info("Mailbox '#{mbox.pathname}' is invalid") if !mbox_valid
+      warn_imap = !imap_valid && imap.exist?
+      Logger.logger.info("Metadata file '#{imap.pathname}' is invalid") if warn_imap
+      warn_mbox = !mbox_valid && mbox.exist?
+      Logger.logger.info("Mailbox '#{mbox.pathname}' is invalid") if warn_mbox
 
       delete
 

lib/imap/backup/version.rb

@@ -6,7 +6,7 @@ module Imap::Backup
   # @private
   MINOR    = 5
   # @private
-  REVISION = 1
+  REVISION = 2
   # @private
   PRE      = nil
   # The application version

spec/unit/serializer_spec.rb

@@ -23,9 +23,11 @@
     before do
       allow(imap).to receive(:pathname) { "imap pathname" }
       allow(imap).to receive(:valid?) { imap_valid }
+      allow(imap).to receive(:exist?) { true }
       allow(imap).to receive(:delete)
       allow(mbox).to receive(:pathname) { "mbox pathname" }
       allow(mbox).to receive(:valid?) { mbox_valid }
+      allow(mbox).to receive(:exist?) { true }
       allow(mbox).to receive(:delete)
 
       action.call