Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please can you preserve the original file date and timestamps #5476

Open
2 tasks done
quakerid opened this issue Feb 8, 2025 · 16 comments
Open
2 tasks done

Please can you preserve the original file date and timestamps #5476

quakerid opened this issue Feb 8, 2025 · 16 comments
Labels

Comments

@quakerid
Copy link

quakerid commented Feb 8, 2025

Describe the bug

Please can you enable a feature to preserve the original file creation date. When installing a game by using DOSBox-X the original file date/timestamps will be destroyed in some cases.
Is there any way that you can fix this problem, so that the original file date will be preserved when installing a programm by using DOSBox-X.

Steps to reproduce the behaviour

4

Expected behavior

No response

What operating system(s) this bug have occurred on?

Windows 11

What version(s) of DOSBox-X have this bug?

DOSBox-X 2025.02.01

Used configuration

Output log


Additional information

No response

Have you checked that no similar bug report(s) exist?

  • I have searched and didn't find any similar bug report.

Code of Conduct & Contributing Guidelines

  • I agree to follow the code of conduct and the contributing guidelines.
@quakerid quakerid added the bug label Feb 8, 2025
@quakerid
Copy link
Author

quakerid commented Feb 8, 2025

Here you can see an example on what I mean.
The files of the game Heretic are datet on 1995 which is the original date.
The files of the game Spear of Destiny are dated on 2025 whis is not the original date of the files.

Image

Image

@quakerid
Copy link
Author

quakerid commented Feb 8, 2025

Here is also a discussion on the vogonsorg forum:
https://www.vogons.org/viewtopic.php?t=27960

Like I said: The initial file date shall be preserved. DosBox should not destroy or overwrite the initial date of any file.

Although the problem seems to be fixed in the current version it will apear in some cases that DosBox destroys and overwrite the initial date of the files as you can see in the screenshot of the game Spear of destiny.

@maron2000
Copy link
Contributor

maron2000 commented Feb 8, 2025

Spear of destiny uses copy command.
And the thread you mentioned has the answer.
Real DOS doesn't do that

Try the same in a booted DOS.

Edit: Sorry, I thought I tried and got the result, but real dos (PC-DOS 7.0) preserved the timestamp.

@maron2000
Copy link
Contributor

Running the installer (runme.bat) didn't change the timestamp on DOSBox-X prompt (not booted DOS).
Is there some procedure different from yours?

Image

@quakerid
Copy link
Author

quakerid commented Feb 9, 2025

Here is what I exacly did

Image

Image

Image

Image

Started Dosbox-X by clicking Dosbox-X.exe
Mounted the three 3.5 720k Floppy images
Startet the instalation programm by typing install.exe

After the instalation programm has finished, you will see the files with an altered timestamp/file date which is modified from the original/initial date.

Is this being caused by Dosbox-X?

@maron2000
Copy link
Contributor

It seems that the disk images were not original.

I found another set of images with the same installer, and installed it on a genuine PC-DOS.
Timestamps of the files installed were not those of the files in the diskette, but the time and date of install.
Therefore, it is the installer that changes the timestamp, and DOSBox-X accurately emulates the behavior of genuine DOS in this situation.

Image

@maron2000
Copy link
Contributor

Same result on VMWare.
Not a bug of DOSBox-X.

Image

Image

@quakerid
Copy link
Author

quakerid commented Feb 9, 2025

So you did use a real DOS Operating System to try this? Not an emulator?
If this happens even under real DOS it indeed could be the installer that changes the date.

@maron2000
Copy link
Contributor

Please look at the screenshot carefully.
I used real DOS on DOSBox-X and VMware, and both behaves the same as emulated DOS on DOSBox-X.
I don't think I have to explain that VMware can only run real DOS.

If you really suspect this, try it on a real DOS on a real machine.

@quakerid
Copy link
Author

quakerid commented Feb 9, 2025

I tried another game Terminal Velocity on 6 Disk Images.
Same Problem. Timestamps were destroyed.
I'm not sure if its caused by Dosbox-X or the instalation programm.

Image

Image

Image

Image

Please can your development team take care of this.

@rderooy
Copy link
Contributor

rderooy commented Feb 9, 2025

If files are copied by the installer, of course the timestamps are going to be updated. It is after all the last-modified timestamp.

DOS filesystems only had a single timestamp, other filesystems such as those used for Unix/Linux operating systems typically have multiple (birth, last accessed, last modified, ...)

So there is nothing wrong.

@quakerid
Copy link
Author

quakerid commented Feb 10, 2025

I Tried the same on Heretic.
In this case the fildate will remain the original/initial/birth date.
Why the filedate does not change in this case?

Image

Image

Image

@maron2000
Copy link
Contributor

Ask H.Yoshizaki, the author of LHA why he decided to keep the timestamp.

@joncampbell123
Copy link
Owner

If the DOS game takes the effort to change the timestamp after writing the file, then it will reflect that timestamp. Otherwise, the timestamp is set to the current time and date.

@quakerid
Copy link
Author

If the DOS game takes the effort to change the timestamp after writing the file, then it will reflect that timestamp. Otherwise, the timestamp is set to the current time and date.

Is this exactly the same behavior like on a real PC under real DOS?
Will MS-DOS in real DOS Environment behave differently from the Dosbox-X Emulator?
If you own a real PC with real DOS you should compare it to each other.

@rderooy
Copy link
Contributor

rderooy commented Feb 11, 2025

Is this exactly the same behavior like on a real PC under real DOS? Will MS-DOS in real DOS Environment behave differently from the Dosbox-X Emulator? If you own a real PC with real DOS you should compare it to each other.

Yes, this is how real DOS behaves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants