We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's a lot of pain in dealing with panic from lib, especially working with background services.
At least I'd like to remove panics came across with tag asserts (#229 #211).
How about turn assert_eq!(tag.as_bytes(), match_tag.as_bytes()); to a new imap::error::Error variant Fatal(FatalError) with some fatal error flag like FatalErrorOccurred: bool, and check FatalErrorOccurred flag before any run_command()?
assert_eq!(tag.as_bytes(), match_tag.as_bytes());
Fatal(FatalError)
FatalErrorOccurred: bool
FatalErrorOccurred
run_command()
FatalError could be like this:
FatalError
enum FatalError{ TagBroken, Other, }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
There's a lot of pain in dealing with panic from lib, especially working with background services.
At least I'd like to remove panics came across with tag asserts (#229 #211).
How about turn
assert_eq!(tag.as_bytes(), match_tag.as_bytes());
to a new imap::error::Error variantFatal(FatalError)
with some fatal error flag likeFatalErrorOccurred: bool
, and checkFatalErrorOccurred
flag before anyrun_command()
?FatalError
could be like this:The text was updated successfully, but these errors were encountered: