Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Annotate PDF in Xournal++ option in file context-menu #6

Open
ranieldias opened this issue Oct 2, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@ranieldias
Copy link

Describe the bug
I'm using Obsidian (.deb) on PopOS, with Xournall++ (.deb). All the settings are ok, and the icon for "New Xournal" is working, but when I'm on a PDF or right-click a PDF I can't edit it with Xournal.

To Reproduce
Steps to reproduce the behavior:

  1. Install Obsidian (.deb) and Xounal++ (.deb)
  2. Set the plugin
  3. Open a PDF on the Vault or Right-Click a PDF on the Vault.

Expected behavior
An option to "Edit with Xournal".

Screenshots
image

Operating System and Versions

  • OS: Linux - PopOS 22.04 LTS
  • Obsidian version: 1.6.7
  • Xournal++ version: 1.1.1
  • Xournal++ Plugin version: 1.0.6
@ranieldias ranieldias added the bug Something isn't working label Oct 2, 2024
@jonjampen
Copy link
Owner

jonjampen commented Oct 2, 2024

Thanks for your message!

At the moment, the plugin does not support directly opening or editing a PDF as an annotation in Xournal++. The reason being that the latest release of Xournal++ does not include a command for using a PDF as an anntoation background yet. However, this feature was since added (here) and is available in the nightly build (version 1.2.3+dev) but not the official release.

The current functionality of my plugin allows you to click Open in Xournal++ on a PDF only if a corresponding XOPP file already exists with the same name and location as the PDF.

The intended workflow is that you create an XOPP file through Obsidian, which the plugin automatically converts to a PDF initially and then whenever changes are made. You can then right-click that PDF in Obsidian and click Open in Xournal++. Any further changes saved in Xournal++ will automatically update the PDF in Obsidian.

I plan to implement the Edit in Xournal++ feature soon as an experimental feature that can be activated by the users that use the nightly build of Xournal++. I'll change this bug report to a feature request.

For now, if you want to annotate a PDF, you can:

  1. Create a new XOPP file using the plugin.
  2. Open it in Xournal++.
  3. In Xournal++, select the PDF as an annotation background.
  4. Save your changes in Xournal++, and the plugin will automatically update the PDF with the new annotations.

I hope this workaround helps for now! Feel free to reach out if you have any other questions or suggestions. I appreciate your patience, and I'll work on getting the Edit in Xournal++ feature ready as soon as possible.

@jonjampen jonjampen added enhancement New feature or request and removed bug Something isn't working labels Oct 2, 2024
@ranieldias
Copy link
Author

Thanks for the answear!

I missunderstand this feature:

  • Access the "Edit in Xournal++" option via an icon in the PDF preview as well as in file explorer (by clicking on X++), enabling quick navigation to the corresponding Xournal++ file.

Anyway, i really like the plugin, it's helping me start with Obsidian and tasks management. I'll wait for the feature and follow the steps above whiule it's not avaliable.

@FancyBEAST
Copy link

FancyBEAST commented Dec 27, 2024

I plan to implement the Edit in Xournal++ feature soon as an experimental feature that can be activated by the users that use the nightly build of Xournal++. I'll change this bug report to a feature request.

+1 for this

@jonjampen jonjampen changed the title Edit on Xournall++ don't shows on PDFs Feature: Annotate PDF in Xournal++ option in file context-menu Dec 28, 2024
@jonjampen jonjampen reopened this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants