Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E some way to launch stack in github actions to test out PRs #135

Closed
joshzcold opened this issue Jan 2, 2025 · 5 comments
Closed

E2E some way to launch stack in github actions to test out PRs #135

joshzcold opened this issue Jan 2, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@joshzcold
Copy link
Owner

We should have some way to launch tests when we get PRs, but Im not sure if there is a free solution in github actions.

Would require either

  • launch the all in one image after building it
  • launch the docker compose dev stack.
  • Running headless e2e tests and capturing their exit code/report
@joshzcold joshzcold added the enhancement New feature or request label Jan 2, 2025
@karlromets
Copy link
Collaborator

karlromets commented Jan 5, 2025

Github has 2000 free minutes of CI/CD. Using self-hosted runners is also an option, but Github says that this might be insecure due to you running unknown code on your machine. Act (for local testing) seems to be something to look at as well. Going by the 2000 free minutes idea, should somehow limit PR-s as malicious people might spam PR-s which would cause you to run out pretty quick.

@joshzcold
Copy link
Owner Author

Looks like Github Actions can have an option to "approve" a job before it actually kicks off
https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-deployments/reviewing-deployments

So we can make it so the job pings us to manually press the go button after reviewing the code.

@joshzcold
Copy link
Owner Author

This now works with the !test comment (only for my user)

Ideally we should be able to get the results back to the PR and allow all maintainers to trigger the tests.

@karlromets
Copy link
Collaborator

This seems helpful, however since I can't access repository settings it's something you would have to take a look at.

@joshzcold
Copy link
Owner Author

I believe what I pushed to master is the functionality we want.

#188 <-- test run.

This will do the lint and e2e test on PR actions.

public forks will require approval before running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants