-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Create documentation on development #160
Conversation
When you get to the part about the makefile, you mention If these files need to be downloaded onto the linux virtual machine thingee, maybe the installation should mention that so people don't have to clone the repo and then move it. ChatGPT is also saying I need to set up some variables in an env file, such as |
Creating documentation that others understand the same way I or @joshzcold do can definitely be a challenge. Regarding the The documentation will need improving, but here’s what worked for me (I’m using Windows):
# Add outbound rules
netsh advfirewall firewall add rule name="WSL2 HTTPS Out" dir=out action=allow protocol=TCP localport=443
netsh advfirewall firewall add rule name="WSL2 HTTP Out" dir=out action=allow protocol=TCP localport=80
# Add inbound rules
netsh advfirewall firewall add rule name="WSL2 HTTPS" dir=in action=allow protocol=TCP localport=443
netsh advfirewall firewall add rule name="WSL2 HTTP" dir=in action=allow protocol=TCP localport=80
nginx proxies back-end and front-end to 443, which means once it is running, it should be accessible on https://localhost/ |
For switching the
If your dev environment is ready to go then it should just be @karlromets would you want to update this branch with your details for getting this working on Windows? |
Yes, once I get the time. I'll mark this as a draft for now. |
I wondered if it mattered where Docker was installed, but after reading this https://docs.docker.com/desktop/features/wsl/#turn-on-docker-desktop-wsl-2 I thought that I could use the one on Windows. It would be nicer too, because VS Code's Docker extension goes looking for that one. I tried running
I'm not sure if I can just I'm definitely missing fundamentals with this new tech stack (last time I contributed in v1, this repo was a simple frontend). I'll probably need to dive into GoLang, WSL, and Docker Hello World projects or something. |
Thank you!!! Ran |
Maybe I spoke too soon. After returning to the project after shutting off the computer, I can get There also aren't any IP4Addresses associated with the containers. I tried adding I have tried running the firewall commands you provided over and over again, keep getting okay, but that doesn't do anything either. I tried step 4 of https://learn.microsoft.com/en-us/windows/wsl/tutorials/wsl-containers, adding Ubuntu22.04. That didn't help either. |
@theredwillow it seems like on windows/wsl you need to go to 127.0.0.1 instead of localhost. Atleast thats what why @karlromets had to put 127.0.0.1 in the e2e tests configuration to get it to work. I wouldn't really expect IP addresses for the containers, but the stack should be accessible at https://127.0.0.1 if the containers have started. |
This worked for a glorious second when I had just started my computer and spun up WSL (before opening Docker Desktop). However, I then tried to make the change you suggested on my draft MR. Then headed over to the Host page from the browser to test it again, when it hit this line of code from ws.current = new WebSocket(`wss://${window.location.host}/api/ws`); I wanted to investigate if my backend was running, so I opened Docker Desktop. I didn't see anything running at all. So I figured it must be using docker inside the WSL. Well, that really upset it because after that, the magical Edit: I wanted to investigate more, but some background process was probably mucking things up, so I restarted my computer again without opening Docker Desktop. This time when I hit the error, I just headed over to
Edit (2): Okay, I think maybe the issue was I still had that port code in there. Once I got rid of that, those GoLang errors went away. So I guess I need to just avoid using Docker Desktop. |
Is The Papa Parse update seems to have alluded my wsl Dockerfile npm install. |
Yeah ran into same issue, run |
…dly-Feud into docs/developer-update
refactor(docs): update devdoc
Going to merge this. I think the doc is sufficient for most work flows and if we need to update it that can be another quick PR. |
Fixes: #115