Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Hyperparameter hits boundary warning #95

Open
samihamdan opened this issue Dec 10, 2020 · 2 comments
Open

[ENH] Hyperparameter hits boundary warning #95

samihamdan opened this issue Dec 10, 2020 · 2 comments
Labels
enhancement New feature or request Priority: Low Low Priority Issue

Comments

@samihamdan
Copy link
Collaborator

throw a warning when the any of the best hyperparameter is at the boundary

@samihamdan samihamdan added the enhancement New feature or request label Dec 10, 2020
@fraimondo fraimondo added this to the v0.3.0 milestone Jul 21, 2022
@fraimondo fraimondo added the Priority: Low Low Priority Issue label Jul 21, 2022
@fraimondo
Copy link
Contributor

This can be implemented inside the run_cross_validation function by inspecting the models after fitting, no? Or we need to patch the *SearchCV objects to check?

@fraimondo
Copy link
Contributor

Implementation:

After the internal call to cross_validate, check if we are doing any of the Grid/Random search and raise warning if the best_hyperparameters of each fold are touching the boundaries.

Caveat: we need to call cross_validate with return estimator = True for each fold, which will increase memory usage if models are too big.

We need to think of an alternative to turn this off, without adding a parameter to run_cross_validation.

@fraimondo fraimondo removed this from the v0.3.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Low Low Priority Issue
Projects
None yet
Development

No branches or pull requests

2 participants