Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Connection header is not mandatory but web socket code expects it. #315

Open
GrahamDumpleton opened this issue Feb 18, 2025 · 0 comments

Comments

@GrahamDumpleton
Copy link

Describe the bug

The HTTP Connection header is not mandatory and should be defaulted to keep-alive in HTTP/1.1.

Even so, the web socket code expects it to exist and will error if not supplied the header.

        start = strstr(handshake, "\r\nConnection: ");
        if (!start) { err("missing Connection header"); return 0; }

Source:

start = strstr(handshake, "\r\nConnection: ");
if (!start) { err("missing Connection header"); return 0; }

KasmVNC Details

Using kasmweb/alpine-320-desktop:1.16.1 from Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant