Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize [ops] and [custom_ops] #1010

Closed
LukeWood opened this issue Nov 14, 2022 · 8 comments · Fixed by #1299
Closed

Reorganize [ops] and [custom_ops] #1010

LukeWood opened this issue Nov 14, 2022 · 8 comments · Fixed by #1299
Labels
api-polish cleanup high-priority process for better process including integration test, benchmark, github action, etc

Comments

@LukeWood
Copy link
Contributor

Currently, we have some tech debt here: ops contains some custom layers as well as some ops. We should really fix this and put the components that are like layers under layers instead of ops. Then we can merge custom_ops into the ops directory.

Its confusing to have both.

@LukeWood LukeWood added high-priority process for better process including integration test, benchmark, github action, etc labels Nov 14, 2022
@bhack
Copy link
Contributor

bhack commented Nov 14, 2022

Do you have any example?

@LukeWood
Copy link
Contributor Author

custom_ops: https://github.com/keras-team/keras-cv/tree/master/keras_cv/custom_ops

should live under ops because it contains tensorflow ops.

ops on the other hand contains a ton of stuff (BoxMatcher, etc), but also IoU3D which is a custom TF op:

https://github.com/keras-team/keras-cv/tree/master/keras_cv/ops

@innat
Copy link
Contributor

innat commented Nov 15, 2022

Why tensorflow ops is here in the first place? Also it looks bazel is reuqired to build custom ops. It looks weird to see these in here as well.

@bhack
Copy link
Contributor

bhack commented Nov 15, 2022

Why tensorflow ops is here in the first place? Also it looks bazel is reuqired to build custom ops. It looks weird to see these in here as well.

What do you mean?

@innat
Copy link
Contributor

innat commented Nov 15, 2022

I mean, why do we need to write C code for some custom operations (ie. PairwiseIou3D?

@bhack
Copy link
Contributor

bhack commented Nov 15, 2022

@innat Probably you missed these threads:
#890 (comment)
openxla/xla#17

@bhack
Copy link
Contributor

bhack commented Nov 15, 2022

@innat And more recently new c++ custom ops with #1020

@LukeWood
Copy link
Contributor Author

Still a few utils to fix

@LukeWood LukeWood reopened this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-polish cleanup high-priority process for better process including integration test, benchmark, github action, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants