Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v5 db schema change #1022

Open
Tracked by #1028
, #1047
...
MarceloRobert opened this issue Feb 28, 2025 · 2 comments · May be fixed by #1035
Open
Tracked by #1028
, #1047
...

Add support for v5 db schema change #1022

MarceloRobert opened this issue Feb 28, 2025 · 2 comments · May be fixed by #1035
Assignees
@murilx

Comments

@MarceloRobert
Copy link
Collaborator

As said in this email, the v5 of the database schema is backwards incompatible, so we should take the necessary precautions to not break the dashboard.
The main problem is the change from build valid to build status, which we are using heavily in the dashboard.

Remember to change all uses in the frontend and also in the backend.
The dashboard should support both schemas while the change is underway, then we can move to support only build status
@MarceloRobert MarceloRobert mentioned this issue Feb 28, 2025
Open
20 tasks
@MarceloRobert
Copy link
Collaborator Author

  • Change build valid to build status
  • Remove test waived from treeDetails query
  • Change the django models

@murilx murilx self-assigned this Mar 5, 2025
@murilx murilx moved this from Todo to In Progress in KernelCI Web Dashboard Mar 5, 2025
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix: update tree details query to schema v5
cbaaeb0 
- Removed "waived" field that's not being used and will be removed in
  the next version of the schema
- Removed other unused fields (e.g. "builds.checkout_id")
- Updated the `get_current_row_data` function
- Moved `get_tree_details_data` to the queries directory

Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix(checkouts): drop support for contacts field
f758729 
Part of #1022
@murilx murilx linked a pull request Mar 5, 2025 that will close this issue
Draft
4 tasks
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix: update tree details query to schema v5
b655458 
- Removed "waived" field that's not being used and will be removed in
  the next version of the schema
- Removed other unused fields (e.g. "builds.checkout_id")
- Updated the `get_current_row_data` function
- Moved `get_tree_details_data` to the queries directory

Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix(checkouts): drop support for contacts field
f21bdca 
Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix: update tree details query to schema v5
fdc8caa 
- Removed "waived" field that's not being used and will be removed in
  the next version of the schema
- Removed other unused fields (e.g. "builds.checkout_id")
- Updated the `get_current_row_data` function
- Moved `get_tree_details_data` to the queries directory

Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
fix(checkouts): drop support for contacts field
98e646a 
Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
feat(build-details-page): add status support
e04ee2a 
Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
feat: update build status
ef24967 
Instead of valid/invalid/null, consider build status equal to test
status and do a mapping from valid to pass, invalid to fail and from
null to null

Part of #1022
murilx added a commit that referenced this issue Mar 5, 2025
@murilx
feat: update build status
6c159e1 
Instead of valid/invalid/null, consider build status equal to test
status and do a mapping from valid to pass, invalid to fail and from
null to null

Part of #1022
murilx added a commit that referenced this issue Mar 7, 2025
@murilx
feat(api): add support for build status
7cbcd03 
The schema v5 will replace Builds.valid for Builds.status that has the
same values as Tests.status. To prepare for this change, we map the
current Builds.valid to its corresponding status (true -> PASS, false ->
FAIL and null -> NULL) and change every system that used the old values
for the new ones

Closes #1022
murilx added a commit that referenced this issue Mar 7, 2025
@murilx
feat(api): add support for build status
691391b 
The schema v5 will replace Builds.valid for Builds.status that has the
same values as Tests.status. To prepare for this change, we map the
current Builds.valid to its corresponding status (true -> PASS, false ->
FAIL and null -> NULL) and change every system that used the old values
for the new ones

Closes #1022
murilx added a commit that referenced this issue Mar 7, 2025
@murilx
feat(api): add support for build status
d541cd5 
The schema v5 will replace Builds.valid for Builds.status that has the
same values as Tests.status. To prepare for this change, we map the
current Builds.valid to its corresponding status (true -> PASS, false ->
FAIL and null -> NULL) and change every system that used the old values
for the new ones

Closes #1022
murilx added a commit that referenced this issue Mar 7, 2025
@murilx
feat(api): add support for build status
dd65d0d 
The schema v5 will replace Builds.valid for Builds.status that has the
same values as Tests.status. To prepare for this change, we map the
current Builds.valid to its corresponding status (true -> PASS, false ->
FAIL and null -> NULL) and change every system that used the old values
for the new ones

Closes #1022
@MarceloRobert MarceloRobert mentioned this issue Mar 10, 2025
Open
20 tasks
@murilx
Copy link
Contributor

murilx commented Mar 10, 2025

This task is currently on pause while we add the tests for every endpoint that will be modified in this schema change. The mapped endpoints so far are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murilx murilx

Labels
None yet
Projects
KernelCI Web Dashboard
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: schema v5 support kernelci/dashboard
2 participants
@murilx @MarceloRobert