Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit and cleanup go deps #10516

Open
lgadban opened this issue Jan 27, 2025 · 3 comments · Fixed by #10529 or #10531
Open

audit and cleanup go deps #10516

lgadban opened this issue Jan 27, 2025 · 3 comments · Fixed by #10529 or #10531

Comments

@lgadban
Copy link
Contributor

lgadban commented Jan 27, 2025

  • remove solo-kit
  • remove skv2
  • audit and remove other solo-io utils modules
    • focus on those with a k8s runtime dep?
  • remove all the go mod replace
@lgadban lgadban converted this from a draft issue Jan 27, 2025
@lgadban lgadban moved this to Planned in Kgateway Planning Jan 28, 2025
@lgadban lgadban linked a pull request Jan 28, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Planned to Done in Kgateway Planning Jan 28, 2025
@lgadban
Copy link
Contributor Author

lgadban commented Jan 28, 2025

majority of outlined work handled in #10529

leftover:

  • audit and remove other solo-io utils modules
    • focus on those with a k8s runtime dep?

@lgadban lgadban reopened this Jan 28, 2025
@lgadban lgadban moved this from Done to Planned in Kgateway Planning Jan 28, 2025
@lgadban lgadban linked a pull request Jan 28, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Planned to Done in Kgateway Planning Jan 28, 2025
@lgadban
Copy link
Contributor Author

lgadban commented Jan 29, 2025

#10531 handled more, but go-utils is left!

@lgadban lgadban reopened this Jan 29, 2025
@lgadban lgadban moved this from Done to Planned in Kgateway Planning Jan 30, 2025
@timflannagan
Copy link
Member

There's a bunch of cleanup we can do here:

  • Migrate the github.com/avast/retry-go to github.com/avast/retry-go/v4
  • Remove github.com/fgrosse/zaptest as there's a single reference in favor of something else that creates a logger
  • Consolidate YAML-related dependencies (e.g. github.com/ghodss/yaml, sigs.k8s.io/yaml) if possible
  • Consolidate error handling libraries (e.g. github.com/rotisserie/eris and github.com/pkg/errors)
  • Determine whether we still need the github.com/saiskee/gettercheck tool
  • Removed the github.com/solo-io/go-list-licenses (and it's corresponding package)
  • Determine how much github.com/solo-io/go-utils can be ripped out
  • Replace github.com/spf13/afero with the stdlib fs.FS (if possible)
  • Remove github.com/spf13/pflag in favor of cobra flags. It's just used in docs/
  • Remove github.com/stoewer/go-strcase. It's just used in the docs/
  • Removed the knative.dev/pkg. There's a minimal number of imports. Manually vendor any of the utilities depending on their LICENSE.

And some open questions:

  • Ideally consolidate on ginkgo or github.com/stretchr/testify or stdlib. That's likely too much work to tackle right now
  • Do we need go.uber.org/zap given the other github.com/go-logr dependencies?
  • Do we need helm.sh/helm/v3 if it's used in install/test and test/. Can we split those into their own modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

2 participants