-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kindelia publish
improvement
#228
Comments
kindelia publish [FILE]
improvement kindelia publish
improvement
Hum, this would be complementary to the functionality of Also, we should make the mempool work nicely with rollback. One simple way to do this would be to re-add the transactions from the removed blocks back to the mempool. (I think you have misdiagnosed the problem: it is that the relevant transactions are being removed from the chain itself, no the mempool.) |
Oh, that makes sense. |
Could elaborating... it seems to me that the ideal behavior would be that Since "real" atomic behavior is probably asking for too much, that's why I wonder if I'm not an eth guy so I don't know how they do it, or other smart contract platforms. But it seems like this should be a mostly solved problem by now? I don't know.... eager to learn. |
@dan-da That's exactly what I was thinking of doing in the future. :)
Yeap, we can't have an atomic publish. One publishes their transactions and "hope" they will not be mined after third-party transactions that wreck them. As the unit of code is a statement and we can't compound them, the user would bind multiple statements to a single reward like this:
Of course, this will only work properly with a set of transactions that fit in a single block (otherwise the miner can't be sure it will be rewarded for the block space it's spending). So the tooling would also help the user to split the transactions into multiple rewards, each going into a different block. |
if a rollback happens when there is a
publish
in the mempool, thatpublish
will be removed from the mempool, and so, you need topublish
the file again. Since it's the same file, it's bound to add alreadypublish
edfun
s andctr
s to the mempool, which is a pain in the ass, considering the fact that the node will receive everything, including "repeated" things, returning a wall ofERROR
s, wasting a lot of time, just to get another rollback, and the cycle repeats.That being said, i think it would be pretty useful to have a command like:
or
that ignores already
publish
ed functions and only adds to the mempool those that "didn't fail"The text was updated successfully, but these errors were encountered: