Merge branch 'rs/reftable-reader-new-leakfix'

gitster · gitster · commit 3dea2ad17d01 · 2025-03-05T10:37:46.000-08:00
Leakfix.

* rs/reftable-reader-new-leakfix:
  reftable: release name on reftable_reader_new() error
diff --git a/reftable/reader.c b/reftable/reader.c
@@ -666,6 +666,8 @@ int reftable_reader_new(struct reftable_reader **out,
 	reftable_block_done(&footer);
 	reftable_block_done(&header);
 	if (err) {
+		if (r)
+			reftable_free(r->name);
 		reftable_free(r);
 		block_source_close(source);
 	}

Original file line number	Diff line number	Diff line change
`@@ -666,6 +666,8 @@ int reftable_reader_new(struct reftable_reader **out,`
`666`	`666`	`reftable_block_done(&footer);`
`667`	`667`	`reftable_block_done(&header);`
`668`	`668`	`if (err) {`
	`669`	`+ if (r)`
	`670`	`+ reftable_free(r->name);`
`669`	`671`	`reftable_free(r);`
`670`	`672`	`block_source_close(source);`
`671`	`673`	`}`