From bbbd4e2b864cdc74991e67446cfdf42c03cea563 Mon Sep 17 00:00:00 2001 From: Guzman Date: Sat, 25 Jan 2025 18:33:25 +0100 Subject: [PATCH] sample-app: Use hardcoded URL as db-insert trigger subscriber This is needed because the node-server service listens on port 8080, and the K8s ref resolver doesn't support custom ports [1], and referring to the node-server-svc service yields: http://node-server-svc.default.svc.cluster.local/insert Instead of the correct URL: http://node-server-svc.default.svc.cluster.local:8080/insert Which results in hanging connections and eventually timeouts when adding new comments that pass the trigger's filter. [1] https://github.com/knative/pkg/blob/dcf159339de2fec9dde678a04cb7a354e912d2bf/resolver/addressable_resolver.go#L227 Signed-off-by: Guzman --- .../solution/node-server/config/200-broker.yaml | 6 +----- docs/bookstore/page-6/advanced-event-filtering.md | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/code-samples/eventing/bookstore-sample-app/solution/node-server/config/200-broker.yaml b/code-samples/eventing/bookstore-sample-app/solution/node-server/config/200-broker.yaml index 64da1d67df6..9f8f630d385 100644 --- a/code-samples/eventing/bookstore-sample-app/solution/node-server/config/200-broker.yaml +++ b/code-samples/eventing/bookstore-sample-app/solution/node-server/config/200-broker.yaml @@ -15,8 +15,4 @@ spec: type: moderated-comment # This is the filter that will be applied to the event, only events with the ce-type moderated-comment will be processed badwordfilter: good # This is the filter that will be applied to the event, only events with the ce-extension badwordfilter: good will be processed subscriber: - ref: - apiVersion: v1 - kind: Service - name: node-server-svc - uri: /insert # This is the path where the event will be sent to the subscriber, see /insert in node-server code: index.js + uri: http://node-server-svc.default.svc.cluster.local:8080/insert # This is the path where the event will be sent to the subscriber, see /insert in node-server code: index.js diff --git a/docs/bookstore/page-6/advanced-event-filtering.md b/docs/bookstore/page-6/advanced-event-filtering.md index e3d461c7017..ded562eaa53 100644 --- a/docs/bookstore/page-6/advanced-event-filtering.md +++ b/docs/bookstore/page-6/advanced-event-filtering.md @@ -36,11 +36,7 @@ Append the following Trigger configuration to the existing `node-server/config/2 type: moderated-comment # This is the filter that will be applied to the event, only events with the ce-type moderated-comment will be processed badwordfilter: good # This is the filter that will be applied to the event, only events with the ce-extension badwordfilter: good will be processed subscriber: - ref: - apiVersion: v1 - kind: Service - name: node-server-svc - uri: /insert # This is the path where the event will be sent to the subscriber, see /insert in node-server code: index.js + uri: http://node-server-svc.default.svc.cluster.local:8080/insert # This is the path where the event will be sent to the subscriber, see /insert in node-server code: index.js ``` ```shell