Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant and confusing labels added by default #2565

Open
rhuss opened this issue Nov 5, 2024 · 2 comments
Open

Redundant and confusing labels added by default #2565

rhuss opened this issue Nov 5, 2024 · 2 comments

Comments

@rhuss
Copy link
Contributor

rhuss commented Nov 5, 2024

When deploying a function, I get a KService with the following metadata:

metadata:
  annotations:
    dapr.io/app-id: demo
    dapr.io/app-port: "8080"
    dapr.io/enable-api-logging: "true"
    dapr.io/enabled: "true"
    dapr.io/metrics-port: "9092"
    serving.knative.dev/creator: kubernetes-admin
    serving.knative.dev/lastModifier: kubernetes-admin
  labels:
    boson.dev/function: "true"
    boson.dev/runtime: quarkus
    function.knative.dev: "true"
    function.knative.dev/name: demo
    function.knative.dev/runtime: quarkus

This is quite noisy and adds a (soft) dependency on Dapr, which I would not add by default. It is confusing for people not using Dapr to see such annotations on their services unconditionally.

My proposal:

  • Make adding the dapr.io annotations optional and enable them only when a Dapr installation is detected or configured by the user.
  • Remove the boson.dev annotations, they are redundant
  • Remove function.knative.dev as it is redundant and adds some noise. You can always check for the existence of function.knative.dev/name like with kubectl get pods -l function.knative.dev/name. Removing that function.knative.dev annotation would avoid inconsistencies when it is set but the name is not (like when manually edited).
Copy link
Contributor

github-actions bot commented Feb 4, 2025

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2025
@rhuss
Copy link
Contributor Author

rhuss commented Feb 4, 2025

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant