Skip to content

Commit 376606f

Browse files
authored
adds automatic browser open (#622)
* adds automatic browser open * adds argo workflows port forward
1 parent a6d4107 commit 376606f

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

cmd/createGithubK3d.go

-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ var createGithubK3dCmd = &cobra.Command{
196196
//* vault in running state
197197
executionControl = viper.GetBool("vault.status.running")
198198
if !executionControl {
199-
// TODO: K3D => We need to check what changes for vault on raft mode, without terraform to unseal it
200199
informUser("Waiting for vault to be ready", globalFlags.SilentMode)
201200
waitVaultToBeRunning(globalFlags.DryRun)
202201
if err != nil {

cmd/postInstall.go

+11-2
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@ package cmd
22

33
import (
44
"fmt"
5-
"github.com/kubefirst/kubefirst/internal/k8s"
65
"log"
76
"net/http"
87
"runtime"
98
"sync"
109
"time"
1110

11+
"github.com/kubefirst/kubefirst/internal/k8s"
12+
1213
"github.com/kubefirst/kubefirst/internal/flagset"
1314
"github.com/kubefirst/kubefirst/internal/reports"
1415

@@ -151,7 +152,15 @@ func isConsoleUIAvailable(url string) error {
151152
func openPortForwardForKubeConConsole() error {
152153

153154
var wg sync.WaitGroup
154-
wg.Add(7)
155+
wg.Add(8)
156+
// argo workflows
157+
go func() {
158+
_, err := k8s.PortForward(false, "argo", "svc/argo-server", "2746:2746")
159+
if err != nil {
160+
log.Println("error opening Argo Workflows port forward")
161+
}
162+
wg.Done()
163+
}()
155164
// argocd
156165
go func() {
157166
_, err := k8s.PortForward(false, "argocd", "svc/argocd-server", "8080:80")

internal/handlers/github.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"io"
88
"log"
99
"net/http"
10+
"os/exec"
1011
"time"
1112

1213
"github.com/kubefirst/kubefirst/internal/reports"
@@ -79,8 +80,8 @@ func (handler GitHubHandler) AuthenticateUser() (string, error) {
7980
fmt.Println(reports.StyleMessage(gitHubTokenReport))
8081

8182
// todo add a 10 second countdown to warn browser open
82-
//time.Sleep(8 * time.Second)
83-
//exec.Command("open", "https://github.com/login/device").Start()
83+
time.Sleep(5 * time.Second)
84+
exec.Command("open", "https://github.com/login/device").Start()
8485

8586
// todo: improve the logic for the counter
8687
var gitHubAccessToken string

0 commit comments

Comments
 (0)