Skip to content

Commit f1dece8

Browse files
author
João Paulo Vanzuita
authored
chore: be louder on port forward errors (#715)
Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io>
1 parent f81f071 commit f1dece8

File tree

1 file changed

+42
-8
lines changed

1 file changed

+42
-8
lines changed

internal/k8s/kubernetes.go

+42-8
Original file line numberDiff line numberDiff line change
@@ -485,18 +485,26 @@ func OpenPortForwardForKubeConConsole() error {
485485
wg.Add(8)
486486
// argo workflows
487487
go func() {
488-
_, err := PortForward(false, "argo", "svc/argo-server", "2746:2746")
488+
output, err := PortForward(false, "argo", "svc/argo-server", "2746:2746")
489489
if err != nil {
490490
log.Println("error opening Argo Workflows port forward")
491491
}
492+
stderr := fmt.Sprint(output.Stderr)
493+
if len(stderr) > 0 {
494+
log.Println(stderr)
495+
}
492496
wg.Done()
493497
}()
494498
// argocd
495499
go func() {
496-
_, err := PortForward(false, "argocd", "svc/argocd-server", "8080:80")
500+
output, err := PortForward(false, "argocd", "svc/argocd-server", "8080:80")
497501
if err != nil {
498502
log.Println("error opening ArgoCD port forward")
499503
}
504+
stderr := fmt.Sprint(output.Stderr)
505+
if len(stderr) > 0 {
506+
log.Println(stderr)
507+
}
500508
wg.Done()
501509
}()
502510

@@ -511,46 +519,67 @@ func OpenPortForwardForKubeConConsole() error {
511519

512520
// chartmuseum
513521
go func() {
514-
_, err := PortForward(false, "chartmuseum", "svc/chartmuseum", "8181:8080")
522+
output, err := PortForward(false, "chartmuseum", "svc/chartmuseum", "8181:8080")
515523
if err != nil {
516524
log.Println("error opening Chartmuseum port forward")
517525
}
526+
stderr := fmt.Sprint(output.Stderr)
527+
if len(stderr) > 0 {
528+
log.Println(stderr)
529+
}
518530
wg.Done()
519531
}()
520532

521533
// vault
522534
go func() {
523-
_, err := PortForward(false, "vault", "svc/vault", "8200:8200")
535+
output, err := PortForward(false, "vault", "svc/vault", "8200:8200")
524536
if err != nil {
525537
log.Println("error opening Vault port forward")
526538
}
539+
stderr := fmt.Sprint(output.Stderr)
540+
if len(stderr) > 0 {
541+
log.Println(stderr)
542+
}
543+
527544
wg.Done()
528545
}()
529546

530547
// minio
531548
go func() {
532-
_, err := PortForward(false, "minio", "svc/minio", "9000:9000")
549+
output, err := PortForward(false, "minio", "svc/minio", "9000:9000")
533550
if err != nil {
534551
log.Println("error opening Minio port forward")
535552
}
553+
stderr := fmt.Sprint(output.Stderr)
554+
if len(stderr) > 0 {
555+
log.Println(stderr)
556+
}
536557
wg.Done()
537558
}()
538559

539560
// minio console
540561
go func() {
541-
_, err := PortForward(false, "minio", "svc/minio-console", "9001:9001")
562+
output, err := PortForward(false, "minio", "svc/minio-console", "9001:9001")
542563
if err != nil {
543564
log.Println("error opening Minio-console port forward")
544565
}
566+
stderr := fmt.Sprint(output.Stderr)
567+
if len(stderr) > 0 {
568+
log.Println(stderr)
569+
}
545570
wg.Done()
546571
}()
547572

548573
// Kubecon console ui
549574
go func() {
550-
_, err := PortForward(false, "kubefirst", "svc/kubefirst-console", "9094:80")
575+
output, err := PortForward(false, "kubefirst", "svc/kubefirst-console", "9094:80")
551576
if err != nil {
552577
log.Println("error opening Kubefirst-console port forward")
553578
}
579+
stderr := fmt.Sprint(output.Stderr)
580+
if len(stderr) > 0 {
581+
log.Println(stderr)
582+
}
554583
wg.Done()
555584
}()
556585

@@ -562,9 +591,14 @@ func OpenPortForwardForKubeConConsole() error {
562591
// OpenAtlantisPortForward opens port forward for Atlantis
563592
func OpenAtlantisPortForward() error {
564593

565-
_, err := PortForward(false, "atlantis", "svc/atlantis", "4141:80")
594+
output, err := PortForward(false, "atlantis", "svc/atlantis", "4141:80")
566595
if err != nil {
567596
return errors.New("error opening Atlantis port forward")
568597
}
598+
stderr := fmt.Sprint(output.Stderr)
599+
if len(stderr) > 0 {
600+
return errors.New(stderr)
601+
}
602+
569603
return nil
570604
}

0 commit comments

Comments
 (0)