Rename argument from namespace to language

Author: seddonym

src/lib.rs

@@ -21,9 +21,9 @@ struct Bundle {
 #[pymethods]
 impl Bundle {
     #[new]
-    fn new(namespace: &str, ftl_filenames: &'_ Bound<'_, PyList>) -> PyResult<Self> {
-        let langid_en: LanguageIdentifier = namespace.parse().expect("Parsing failed");
-        let mut bundle = FluentBundle::new_concurrent(vec![langid_en]);
+    fn new(language: &str, ftl_filenames: &'_ Bound<'_, PyList>) -> PyResult<Self> {
+        let langid: LanguageIdentifier = language.parse().expect("Parsing failed");
+        let mut bundle = FluentBundle::new_concurrent(vec![langid]);
 
         for file_path in ftl_filenames.iter() {
             let path_string = file_path.to_string();

src/rustfluent.pyi

@@ -1,3 +1,3 @@
 class Bundle:
-    def __init__(self, namespace: str, ftl_filenames: list[str]) -> None: ...
+    def __init__(self, language: str, ftl_filenames: list[str]) -> None: ...
     def get_translation(self, identifier: str, **kwargs: str) -> str: ...

tests/test_python_interface.py

@@ -15,6 +15,14 @@ def test_en_basic():
     assert bundle.get_translation("hello-world") == "Hello World"
 
 
+def test_en_basic_with_named_arguments():
+    bundle = fluent.Bundle(
+        language="en",
+        ftl_filenames=[str(data_dir / "en.ftl")],
+    )
+    assert bundle.get_translation("hello-world") == "Hello World"
+
+
 def test_en_with_args():
     bundle = fluent.Bundle("en", [str(data_dir / "en.ftl")])
     assert bundle.get_translation("hello-user", user="Bob") == "Hello, \u2068Bob\u2069"