Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BranchRestrictions Create and Get should not return BranchRestrictions #146

Open
DataDavD opened this issue Jul 5, 2021 · 2 comments
Open

Comments

@DataDavD
Copy link
Contributor

DataDavD commented Jul 5, 2021

hey @ktrysmt I took a further look at #144 and it seems like the BranchRestrictions Create and Get methods need a little work as well. I got rid of the unneeded interface type assertion for the Create tests (since it no longer returns an interface testing a type is redundant given compilation checks types for us) but still had issues with nil pointer deference in the tests which is probably due to the fact that the decode function is returning the same BranchRestrictions type but not specifying the *client.

From my review it appears that a BranchRestrictions Response type needs to be created and the decode function should return that instead.

Is that OK if I work on fixing/adding this stuff?????? The branch/PR for this Issue will close both issues related to branch restrictions.

Thanks in advance.

@DataDavD
Copy link
Contributor Author

Update/FYI I'm currently working on PR to fix this issue, so please no one duplicate this work. PR should be ready this weekend.

@ktrysmt
Copy link
Owner

ktrysmt commented Jul 23, 2021

Yes, it seems a good idea. I want to try to see a POC or PullRequest about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants