-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Home page to include main components and their GitHub Star count #3624
Comments
I'm not sure about this to be honest. |
I think this is great if someone wants to contribute it! |
/help |
@varodrig: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
@andreyvelich: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, I feel at least for KubeFlow we should have github star banner for sure. Something like this, I will improve the UI and attract new contributors. But for individual components to have that banner, I am personally not very fan of that since these components come under the umbrella of Kubeflow MLF, while Argo's individual tools are a bit more independent from each other. For distributions star's, we already have a related PR #3598 Feel free to suggest what you all think would be better. |
Your thoughts on the above suggestion, @varodrig @andreyvelich ? |
I would prefer if we have star banner for every Kubeflow project, since all of them can be used as a standalone project. |
Hi, so I was kinda working on it to find which one suits better. I added shields icon, since it can be easily added to markdown. ![]() |
Looks amazing @jaiakash. |
![]() For the main kubeflow repo, I added it in the navbar. Personally I feel for this navbar we should have a better design. Fork link: https://github.com/jaiakash/website/tree/github-stars |
@andreyvelich I am ok with having the
However, I don't like the per-component start counts on the homepage for a few reasons:
Instead, we could possibly include the star counts on the overview page on each component, instead of the homepage. |
Also, there is a slight privacy (and website-reliability) concern with including the "shields" image (which is hosted by another service) on literally every page of the website. |
I think, it is less important to have stars for |
I have a slightly different opinion here. GitHub stars is a misleading metric and people often take it in the wrong way. Not a strong objection though. If we do end up doing this, we should not include stars from |
I agree with @thesuperzapper 's first point, We should have a star count for For ques,
Actually, I am looking to create a custom component that is more suited for the KubeFlow website's theme, covering both mobile view and dark mode. |
Feature request
On the https://www.kubeflow.org/ home page, add the below components image/logo with their Github repo link and the respective Github repo star count
Something like this is done by Argo project for their components, reference https://argoproj.github.io/
The text was updated successfully, but these errors were encountered: