Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change .publicKey() method on builders to .identifier(). #48

Closed
KwilLuke opened this issue Nov 27, 2023 · 0 comments
Closed

Change .publicKey() method on builders to .identifier(). #48

KwilLuke opened this issue Nov 27, 2023 · 0 comments
Assignees
@KwilLuke
Labels
enhancement New feature or request

Comments

@KwilLuke
Copy link
Contributor

Once #38 is completed (i.e. the actionBuilder and dbBuilder) public APIs are removed, the .publicKey() methods on the builders should be changed to .identifier(), to be consistent with the concept of identifiers being determined by the signer used on the Kwil database.

More info here: kwilteam/kwil-db#390
@KwilLuke KwilLuke added the enhancement New feature or request label Nov 27, 2023
@KwilLuke KwilLuke self-assigned this Nov 27, 2023
@KwilLuke KwilLuke closed this as completed Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KwilLuke KwilLuke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KwilLuke