Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisCluster: native redis increment and decrement functionality #65

Closed
boesing opened this issue Dec 13, 2022 · 2 comments
Closed

RedisCluster: native redis increment and decrement functionality #65

boesing opened this issue Dec 13, 2022 · 2 comments
Labels
Enhancement Won't Fix This will not be worked on

Comments

@boesing
Copy link
Member

boesing commented Dec 13, 2022

Feature Request

Q A
New Feature yes

Summary

The StorageInterface provides StorageInterface#decrementItem and StorageInterface#incrementItem. Redis itself has native increment and decrement functionality which is not implemented in the current implementation.

@boesing
Copy link
Member Author

boesing commented Dec 13, 2022

Just as a sidenote:
Imho, the whole increment/decrement stuff should be implemented as a dedicated interface (if at all) to all adapters such as FlushableInterface. The reason is, that the "generic" way on how other backends (and how RedisCluster does as of now) is not race-condition safe and thus might override other countervalues.

Thats why the RFC was raised in laminas-cache in 2021:
laminas/laminas-cache#117

@boesing
Copy link
Member Author

boesing commented Jun 21, 2024

With v4 of laminas-cache and therefore v3 of this adapter, the increment and decrement functionality was removed.
Closing here.

@boesing boesing closed this as completed Jun 21, 2024
@boesing boesing added the Won't Fix This will not be worked on label Jun 21, 2024
@boesing boesing closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Won't Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant