Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return values of some AbstractAdapter methods do not reflect the annotated return type #15

Closed
ravcz opened this issue Jan 16, 2020 · 1 comment · Fixed by #295
Closed
Labels
BC Break Bug Something isn't working
Milestone

Comments

@ravcz
Copy link

ravcz commented Jan 16, 2020

Bug Report

There is wrong return type in

zend-cache/src/Storage/Adapter/AbstractAdapter.php

/**
 * Remove an item.
 *
 * @param  string $key
 * @return bool
 * @throws Exception\ExceptionInterface
 *
 * @triggers removeItem.pre(PreEvent)
 * @triggers removeItem.post(PostEvent)
 * @triggers removeItem.exception(ExceptionEvent)
 */
public function removeItem($key)

Expected behavior

There should be @return mixed

There is calling internally
return $this->triggerPost(FUNCTION, $args, $result);

which is returnng mixed.

@boesing boesing added Bug Something isn't working Good First Issue Good for newcomers labels Jun 5, 2020
@boesing boesing linked a pull request Jun 5, 2020 that will close this issue
@boesing boesing removed the Good First Issue Good for newcomers label Apr 29, 2021
@boesing boesing changed the title Wrong return type Return values of some AbstractAdapter methods do not reflect the annotated return type Apr 29, 2021
@boesing boesing added this to the 3.0.0 milestone Apr 29, 2021
@boesing boesing modified the milestones: 3.0.0, 4.0.0 Jul 31, 2021
@boesing
Copy link
Member

boesing commented Mar 2, 2024

Fixed with #295

@boesing boesing closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Bug Something isn't working
Projects
None yet
2 participants