Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON / YAML schema object flag as Value #3

Closed
lavenderses opened this issue May 5, 2024 · 0 comments · Fixed by #4
Closed

Support JSON / YAML schema object flag as Value #3

lavenderses opened this issue May 5, 2024 · 0 comments · Fixed by #4
Assignees
Labels
enhancement New feature or request requirements Implementation for OpenFeature Provider requirements

Comments

@lavenderses
Copy link
Owner

What

Thanks to #1 and #2, this provider supports boolean feature flas.

Next, this provider implementation should support structure type feature flag.

Because of AWS AppConfig feature flag schema limitation (flag value cannot be nested), how about putting JSON string to flag_value attribute?
I think this is much consistent to other feature flag type...
(In the future, suporting free form configuration is also good,,,
https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-free-form-configurations-creating.html)

{
  "{key name}": {
    "enabled": boolean,
    // "Attribute (optional)"
    "flag_value": { // JSON format
      "foo": "bar",
    }
  }
}

This is the requiremetns 2.2.2.1.

The feature provider interface MUST define methods for typed flag resolution, including boolean, numeric, string, and structure.

Notes

N/A

@lavenderses lavenderses added enhancement New feature or request requirements Implementation for OpenFeature Provider requirements labels May 5, 2024
@lavenderses lavenderses self-assigned this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requirements Implementation for OpenFeature Provider requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant