Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!man incorrectly returned station that has raw materials trader #452

Open
Juvecu opened this issue Oct 19, 2022 · 5 comments
Open

!man incorrectly returned station that has raw materials trader #452

Juvecu opened this issue Oct 19, 2022 · 5 comments

Comments

@Juvecu
Copy link

Juvecu commented Oct 19, 2022

Did a !man to get the nearest manufactured materials trader, but when I arrived at the station it was a raw materials trader instead.

!man Byel Taca to reproduce, the station returned was Melroy Horizons.

I'm on Ody game client.

Screenshot showing raw material trader:
image

Thanks for the great plugin, love it!

@Juvecu
Copy link
Author

Juvecu commented Oct 19, 2022

For what it's worth, I did a !raw a while before that and it got me to a raw materials trader properly.

@Juvecu
Copy link
Author

Juvecu commented Oct 24, 2022

More info on this, just now, while on a carrier in LFT 163 a !raw returned:
image

Searching on Inara it returns a closer location 17.51LY away in LFT 142 at Rozhdestvensky Dock.

Reproducible with !raw LFT 163

@Juvecu
Copy link
Author

Juvecu commented Oct 24, 2022

Similar problem, I am in LHS 1228 and I do !enc and get:
image

!enc LHS 1228 gives same result.

Checking Inara there is an encoded trader 17.01LY away in 9 Ceti at Fanning Vision.

Where is EDR getting my current location from so that I can check if there isn't a problem with that?

@Juvecu
Copy link
Author

Juvecu commented Oct 27, 2022

For the ones where it is showing the correct type, but at a station further away than expected, it looks like there is some sort of filter being applied that relates to the distance a station is from the main star. I've checked the config files and I can't find a user adjustable setting for it. The setting appears quite low as in the above LHS 1228 example the 9 Ceti station is only 2,806Ls from the star. Is there something I can put in my user_config.ini to override this?

@lekeno
Copy link
Owner

lekeno commented Feb 5, 2023

For the closer options, it might be the case that the distance to the station is over the preferred threshold. EDR tries to balance the distance in LY against distance in LS.

For the incorrect results, this is typically because of discrepancies between what the logic is supposed to be vs. what happens in practice (bugs, logic not working as intended). I think Inara has some additional tricks to improve the accuracy (e.g. manual edits for popular locations, reflecting information gathered by users). I will keep this in mind and see if I can easily improve things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants