-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quic): deprecate QUIC draft-29 version support #5786
Open
tesol2y090
wants to merge
20
commits into
libp2p:master
Choose a base branch
from
tesol2y090:feat/quic/deprecated-draft-29
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
538e2ff
feat: deprecated support_draft_29 field
tesol2y090 2a95c84
feat: update changelog
tesol2y090 5958303
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 01552a7
feat: move changelog under 0.11.2
tesol2y090 5596502
chore: add allow deprecated on support_draft_29
tesol2y090 4cfd7eb
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 d3e6a02
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 b802f05
feat: use expect instead of allow
tesol2y090 2ac983c
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 b304418
feat: move expect before function
tesol2y090 0fcf7b1
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 c40abec
Merge branch 'master' into feat/quic/deprecated-draft-29
jxs a897691
feat: add allow deprecated
tesol2y090 56671ff
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 81b87e9
Update transports/quic/src/config.rs
tesol2y090 84d810a
chore: bump version
tesol2y090 23c6036
fix: format
tesol2y090 8af3f27
fix: format
tesol2y090 f373aa2
chore: bump quic version
tesol2y090 364457f
chore: bump quic version
tesol2y090 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ pub struct Config { | |
/// If support for draft-29 is enabled servers support draft-29 and version 1 on all | ||
/// QUIC listening addresses. | ||
/// As client the version is chosen based on the remote's address. | ||
#[deprecated(note = "QUIC draft versions are no longer supported")] | ||
pub support_draft_29: bool, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should probably add an allow on our usage of this field, in |
||
|
||
/// TLS client config for the inner [`quinn::ClientConfig`]. | ||
|
@@ -72,6 +73,7 @@ pub struct Config { | |
mtu_discovery_config: Option<MtuDiscoveryConfig>, | ||
} | ||
|
||
#[expect(deprecated)] | ||
impl Config { | ||
/// Creates a new configuration object with default values. | ||
pub fn new(keypair: &libp2p_identity::Keypair) -> Self { | ||
|
@@ -122,6 +124,7 @@ pub(crate) struct QuinnConfig { | |
pub(crate) endpoint_config: quinn::EndpointConfig, | ||
} | ||
|
||
#[expect(deprecated)] | ||
impl From<Config> for QuinnConfig { | ||
fn from(config: Config) -> QuinnConfig { | ||
let Config { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libp2p-quic-v0.12.0
is already released. You need to bump the version of it to0.12.1
and move this to a new section above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the version of the
libp2p-quic
crate itself also needs to be bumped :)