Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swarm-derive): use full path for std result in derive macros #5843

Closed
wants to merge 8 commits into from

Conversation

jxs
Copy link
Member

@jxs jxs commented Feb 3, 2025

Description

Replace the Result in the ./swarm-derive/src/lib.rs file with std::result::Result.
Fixes #5833
superseeds #5839 as it was created before the git tag existed for lib2p-swarm-derive-v0.35.0

Copy link
Contributor

mergify bot commented Feb 3, 2025

⚠️ The sha of the head commit of this PR conflicts with #5839. Mergify cannot evaluate rules on this PR. ⚠️

@jxs jxs changed the title 5833 fix derive macro fix(swarm-derive): use full path for std result in derive macros Feb 3, 2025
@elenaf9
Copy link
Contributor

elenaf9 commented Feb 3, 2025

Re-ran the jobs for #5839 and the CI passed, so I think we can close this PR?

@elenaf9 elenaf9 closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in derive macro NetworkBehaviour
4 participants