From 9ca4138ff62a1224203b0f6c1b90db80cb03c36b Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Sat, 25 Jan 2025 11:44:27 +0100 Subject: [PATCH 1/2] Add SemVer compatibility checks to CI Even small changes to item visibility during fixes might introduce SemVer violations (see https://doc.rust-lang.org/cargo/reference/semver.html#change-categories for a list of changs that would be considered major/minor). To make sure we don't accidentally introduce such changes, we here add a new semver-checks CI job that utilizes cargo-semver-checks (https://github.com/obi1kenobi/cargo-semver-checks), and have it run on any push or pull requests. --- .github/workflows/semver.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflows/semver.yml diff --git a/.github/workflows/semver.yml b/.github/workflows/semver.yml new file mode 100644 index 000000000..8472cbd2a --- /dev/null +++ b/.github/workflows/semver.yml @@ -0,0 +1,15 @@ +name: SemVer checks +on: [push, pull_request] + +jobs: + semver-checks: + runs-on: ubuntu-latest + steps: + - name: Checkout source code + uses: actions/checkout@v4 + - name: Install Rust stable toolchain + run: | + curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable + rustup override set stable + - name: Check SemVer + uses: obi1kenobi/cargo-semver-checks-action@v2 From 962ab230dbdd5f8fbd78130fa0188843816b1b63 Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Sat, 25 Jan 2025 11:47:51 +0100 Subject: [PATCH 2/2] Bump `Cargo.toml` to WIP version (0.5.0+git) We bump the version number on `main` to the next-planned minor release (mod `+git` metadata tag). This aligns what we're planning to do in LDK (see https://github.com/lightningdevkit/rust-lightning/pull/3546) and allows us to run SemVer checks on PRs towards `main`. --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index c0aad2902..55ffdc5bf 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ldk-node" -version = "0.4.3" +version = "0.5.0+git" authors = ["Elias Rohrer "] homepage = "https://lightningdevkit.org/" license = "MIT OR Apache-2.0"