Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Peer's announcement info if available #278

Closed

Conversation

benthecarman
Copy link

No description provided.

@tnull
Copy link
Collaborator

tnull commented Mar 18, 2024

We may eventually do this or at least expose some of the more important fields, however, unfortunately just exposing NodeAnnouncentInfo as is doesn't play well with our bindings. I'm also on the fence if we shouldn't rather expose APIs to query the network graph generally, as this would provide even more utility and can be helpful for debugging purposes.

@benthecarman
Copy link
Author

Yeah the main thing we were going to use this for was getting the alias, maybe that'd be better to add here instead

@tnull
Copy link
Collaborator

tnull commented Mar 19, 2024

Yeah the main thing we were going to use this for was getting the alias, maybe that'd be better to add here instead

Mhhh, so generally we're in the process of including some more fields in the RGS data, mostly to fix BOLT12 compat issues for RGS users. However, alias likely won't be included to keep the snapshot size small. So the only nodes having it available would be P2P nodes, i.e., exactly not the client-side nodes that likely would want it to show connected nodes in a nicer way. For fully-synced always-on nodes it would make more sense to access the network graph generally, which we should expose eventually.

@benthecarman benthecarman deleted the announcement-info branch March 19, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants