Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax loading on navbar not triggered, if other click handlers present #50

Open
lentschi opened this issue Sep 2, 2016 · 0 comments
Open

Comments

@lentschi
Copy link

lentschi commented Sep 2, 2016

Is suspect a bug here:

if (!handlers || -1 !== $.inArray(onNavbarClick, handlers.click)) {

Maybe I'm misreading your code, but should the !== in ...

if (!handlers || -1 !== $.inArray(onNavbarClick, handlers.click)) {

... not actually be a ===? I debugged it and in my case, since there are already some click events present, it jumps over it. ($.inArray() returns -1 if nothing is found. But if nothing is found, don't we want to add our click handler?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant