Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: NOLINT(misc-include-cleaner) #2566

Open
jwrober opened this issue Mar 18, 2025 · 0 comments
Open

Fix: NOLINT(misc-include-cleaner) #2566

jwrober opened this issue Mar 18, 2025 · 0 comments
Labels
refactoring This issue requires code refactoring

Comments

@jwrober
Copy link
Collaborator

jwrober commented Mar 18, 2025

As part of cleaning up unneeded includes in #2464, there are a number of "unneeded" includes that clang-tidy doesn't think we need, but we do, so we have to use the NOLINT(misc-include-cleaner) comment to supress the check. Ideally we should not need that, but the code should behave. Capturing here.
@jwrober jwrober added the refactoring This issue requires code refactoring label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring This issue requires code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwrober