Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle single quotes better. #378

Closed
sgehrman opened this issue Jan 25, 2024 · 4 comments
Closed

Handle single quotes better. #378

sgehrman opened this issue Jan 25, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sgehrman
Copy link

sgehrman commented Jan 25, 2024

I use single quotes, so I have some strings like 'This is John\'s stuff'

Converting that to double quotes makes it better, but it would be nice if your code worked better.

'This is John\'s stuff'  => "This is John\\'s stuff"

but using double quotes in my code:

"This is John's stuff" => "This is John's stuff"

Also in the app_localizations.dart files you get

'This is John\\\'s stuff'

It would be good if you could not do the \ and just use the ' with double quotes

Small thing, but it looks much cleaner, and I don't want to have to convert to double quotes to get the cleaner version.

@lsaudon lsaudon added the bug Something isn't working label Jan 26, 2024
@lsaudon lsaudon self-assigned this Jan 26, 2024
@lsaudon lsaudon added enhancement New feature or request and removed bug Something isn't working labels Jan 26, 2024
@sgehrman
Copy link
Author

I'm just converting the string to double quotes before adding to arb, so not a big deal, just a suggestion.

@lsaudon
Copy link
Owner

lsaudon commented Jan 29, 2024

Hi @sgehrman, i make this #383.
Is it what you imagined?
I replace \\' with '.
The problem I see is that if someone really wants to \\' it will be replaced.

@lsaudon
Copy link
Owner

lsaudon commented Feb 5, 2024

Add in next release

@lsaudon lsaudon closed this as completed Feb 5, 2024
@lsaudon
Copy link
Owner

lsaudon commented Mar 7, 2024

The feature is present in version 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants