Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default countdown mode set to time of day except countdown after upgrade #49

Closed
lukaslangrock opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lukaslangrock
Copy link
Owner

When users upgrade to 1.3, the settings file does not include a parameter for which countdown mode to use, so the settings gets added and a new boolean initialized, meaning CountdownMode is set to false on upgraded installations, resulting in time of day being the default mode.

New users start with completely empty settings and therefore get the recommended default of ``true` for this setting.

@lukaslangrock lukaslangrock added the bug Something isn't working label Nov 13, 2024
@lukaslangrock lukaslangrock added this to the v1.3.1 milestone Nov 13, 2024
@lukaslangrock lukaslangrock self-assigned this Nov 13, 2024
@lukaslangrock lukaslangrock mentioned this issue Nov 13, 2024
@lukaslangrock lukaslangrock pinned this issue Nov 13, 2024
@lukaslangrock
Copy link
Owner Author

I'll probably also force migrate this to true for people coming from 1.3.0. Any users who intended this to be default in their setup will probably figure this out, but the vast majority is probably confused at the new behavior and either change this manually every time or reconfigured the settings. I expect the negative impact from this bug to be lessened for most people this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant