Skip to content

Commit

Permalink
remove external test dependencies; st matrix tests;
Browse files Browse the repository at this point in the history
  • Loading branch information
m-wrzr committed Feb 2, 2024
1 parent bcb9e4f commit 161ef45
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .github/actions/setup_backend/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ inputs:
description: 'Python version to use'
required: true
default: '3.11'
streamlit-version:
description: 'Streamlit version to use'
required: true
default: '1.31'

runs:
using: composite
Expand All @@ -20,6 +24,9 @@ runs:
shell: bash --login -eo pipefail {0}
run: python -c "import sys; print(sys.version)"

- run: pip install streamlit==${{ inputs.streamlit-version }}"
shell: bash --login -eo pipefail {0}

- run: pip install -e ".[dev,tests]"
shell: bash --login -eo pipefail {0}

Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
streamlit-version: ["1.25", "1.26", "1.27", "1.28", "1.29", "1.30", "1.31"]

steps:
- uses: actions/checkout@v4
Expand All @@ -35,10 +36,16 @@ jobs:
tests:
needs: [pre-commit, types]
runs-on: ubuntu-latest
strategy:
matrix:
streamlit-version: ["1.25", "1.27", "1.29", "1.31"]

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup_frontend
- uses: ./.github/actions/setup_backend
with:
streamlit-version: ${{ matrix.streamlit-version }}

- run: playwright install

Expand Down
3 changes: 2 additions & 1 deletion tests/playwright.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def is_server_running():
"run",
"example_ci.py",
"--server.fileWatcherType=none",
"--global.disableWatchdogWarning=true",
"--logger.level=error",
]
)
Expand Down Expand Up @@ -102,6 +101,8 @@ def test_streamlit_app_loads(streamlit_app):
for b in boxes
if b["label"]
not in [
# ignore since it relies on external api calls
"search_wikipedia_ids",
# ignore since it's has a different behavior
"search_rerun_disabled",
# TODO: make custom tests for these, initial result list makes it harder
Expand Down

0 comments on commit 161ef45

Please sign in to comment.